test: annotate tests with covered SHIP test-spec cases#102
Open
andig wants to merge 1 commit into
Open
Conversation
Add reference comments to the existing tests that already cover conformant SHIP High-Level Test Specification (V1.0.0) requirements, so coverage is explicit and traceable. Comment-only; no behavior or assertion changes. Covers: AM_001, CMI_002/003/004/006, HELLO_001-004, MSG_001/002, PIN_001, PROT_001/002, ROLE_001/002/003, SEC_001/002. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes SHIP High-Level Test Specification (V1.0.0) coverage explicit: adds a one-line
// TC_SHIP_...reference comment to each existing test that already exercises a conformant test-case requirement. Comment-only — no production code, test logic, or assertions changed;./ship ./cert ./hubstay green.Contributes to #95 (SHIP TestSpecification compliance) by making the "already covered" cases traceable in-code.
Annotated
ship/hs_access_test.goTest_Requestship/hs_init_client_test.goTest_ClientWait_InvalidMsgTypeship/hs_init_server_test.goTest_ServerWait_Timeoutship/hs_init_client_test.goTest_ClientWait_Timeoutship/hs_init_client_test.goTest_ClientWait_InvalidDataship/hs_hello_server_test.goTest_ReadyListen_Ok/Prolongation/Timeout/Ignoreship/connection_messaging_coverage_test.goTest_HandleIncomingWebsocketMessage_EdgeCasesship/hs_pin_test.goTest_CheckListen_Noneship/hs_prot_server_test.goTest_ListenProposalship/hs_prot_client_test.goTest_ListenChoiceship/hs_init_server_test.goTest_Startship/hs_init_client_test.goTest_Starthub/hub_connections_client_coverage_test.goTest_KeepThisConnection_DirectTestcert/cert_test.goTest_SkiFromCertificate_SKIMismatchNotes: SEC_001/002 both reduce to the SKI≠SHA-1(pubkey) rejection in
SkiFromCertificate(stacked on the one mismatch test). AM_001's covering test driveshandleAccessMethodsRequest(which setsaccessMethods.id= own SHIP id) but asserts a reply is sent rather than the exact id value.🤖 Generated with Claude Code