Skip to content

Ensure proper Exception inheritance in APIException subclasses #9883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RinZ27 wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −0
Open

Ensure proper Exception inheritance in APIException subclasses #9883

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89020ae
Ensure proper Exception inheritance in APIException subclasses
RinZ27 Feb 5, 2026
ca803a3
Merge branch 'main' into fix-exception-inheritance
browniebroke Jul 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions rest_framework/exceptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ def __init__(self, detail=None, code=None):
code = self.default_code

self.detail = _get_error_details(detail, code)
super().__init__(self.detail)

@browniebroke browniebroke Jul 25, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not passing down the code to this one? This changes the representation of the exception in the REPL and make it quite verbose:

Before

>>> APIException("Invalid input", 400)
APIException('Invalid input', 400)

After

>>> APIException("Invalid input", 400)
APIException(ErrorDetail(string='Invalid input', code=400))


def __str__(self):
return str(self.detail)
Expand Down Expand Up @@ -159,6 +160,7 @@ def __init__(self, detail=None, code=None):
detail = [detail]

self.detail = _get_error_details(detail, code)
super().__init__(self.detail, code)
Comment thread
RinZ27 marked this conversation as resolved.

@browniebroke browniebroke Jul 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar comment on verbosity.

Before

>>> ValidationError("Invalid input", 400)
ValidationError('Invalid input', 400)

After

>>> ValidationError("Invalid input", 400)
ValidationError([ErrorDetail(string='Invalid input', code=400)])



class ParseError(APIException):
Expand Down