Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion rest_framework/fields.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import decimal
import functools
import inspect
import math
import re
import uuid
import warnings
Expand Down Expand Up @@ -973,12 +974,17 @@ def to_internal_value(self, data):
self.fail('max_string_length')

try:
return float(data)
value = float(data)
except (TypeError, ValueError):
self.fail('invalid')
except OverflowError:
self.fail('overflow')

if not math.isfinite(value):
self.fail('invalid')

return value

def to_representation(self, value):
return float(value)

Expand Down
8 changes: 7 additions & 1 deletion tests/test_fields.py
Original file line number Diff line number Diff line change
Expand Up @@ -1243,7 +1243,13 @@ class TestFloatField(FieldValues):
0.0: 0.0,
}
invalid_inputs = {
'abc': ["A valid number is required."]
'abc': ["A valid number is required."],
'nan': ["A valid number is required."],
'inf': ["A valid number is required."],
'-inf': ["A valid number is required."],
'1e400': ["A valid number is required."],
float('nan'): ["A valid number is required."],
float('inf'): ["A valid number is required."],
}
outputs = {
'1': 1.0,
Expand Down
Loading