Sign post: Add unshaded material to label#2405
Merged
Merged
Conversation
This label is not supposed to be part of the world. Add a new CanvasItemMaterial to the PanelContainer and set it to light mode: unshaded.
Collaborator
Author
|
This is subtle but is more evident now that sign posts have a light source. Before: After: |
|
Play this branch at https://play.threadbare.game/branches/endlessm/sign-label-unshaded/. (This launches the game from the start, not directly at the change(s) in this pull request.) |
wjt
approved these changes
Jun 19, 2026
wjt
left a comment
wjt
left a comment
Member
There was a problem hiding this comment.
I have a lot to learn about how lighting works!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This label is not supposed to be part of the world. Add a new CanvasItemMaterial to the PanelContainer and set it to light mode: unshaded.