Add end-to-end test for the claim review MVP flow#70
Closed
enlorik wants to merge 1 commit into
Closed
Conversation
Owner
Author
|
@codex review |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
enlorik
force-pushed
the
feature/claim-review-e2e-mvp-tests
branch
from
July 9, 2026 17:41
fb05eb8 to
967b360
Compare
enlorik
changed the base branch from
main
to
feature/claim-review-provider-guardrails
July 9, 2026 17:45
Owner
Author
|
Superseded by a clean branch rebased onto current main — reopening as new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an end-to-end test for the claim review MVP flow
We had good coverage per-feature (ask, draft, save, append, discard all separately) but nothing walking the whole path in one go, so added a test that drives it start to finish: ask a question, confirm local evidence is fetched before the grounded-answer provider, see new/betterSource claims selected by default and alreadyKnown left out, toggle a claim off, generate the markdown draft, save it as a new note, append the same draft to an existing note, then discard and confirm nothing got deleted. Also checked along the way that the raw grounded-answer text never ends up in the saved markdown and that source links survive into both the saved and appended note content. Added a second smaller test confirming an alreadyKnown claim can't sneak into a saveable draft even if you try to toggle it. All fakes, no real network or API keys. Went from 509 to 511 tests, all green, analyze clean.