feat: claim review draft-generation UI polish#75
Merged
Conversation
…roup helper copy - Generate button requires selectedSaveableItems.isNotEmpty; shows helper text with key generate-draft-disabled-helper in two cases: saveable claims exist but none selected, or no saveable claims exist in the review at all - Add new-claim-helper-text, contradiction-helper-text, uncertain-claim-helper-text to ClaimReviewGroupsPanel per-group sections - Update claim-draft-empty-state copy to "No saveable claims are selected for this draft." - Adapt three tests that tapped the now-disabled Generate button via UI to call notifier.generateDraft() directly; add focused polish tests and group helper tests Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
selectedSaveableItems.isNotEmpty); shows helper text with keygenerate-draft-disabled-helperfor two cases: saveable claims exist but none selected, or no saveable claims in this review at allClaimReviewGroupsPanel:new-claim-helper-text,contradiction-helper-text,uncertain-claim-helper-text;better-source-helper-textunchangedclaim-draft-empty-statecopy updated: "No saveable claims are selected for this draft."No production behavior changes — only UI copy and button enablement gating. Ported cleanly from the old PR #71 (which targeted a now-merged stale base). 601/601 tests pass.
Test plan
flutter test— 601/601 passnew-claim-helper-text,contradiction-helper-text,uncertain-claim-helper-textvisible in groups panelclaim-draft-empty-stateshows updated copy🤖 Generated with Claude Code