security: rate limit password recovery requests#75
Draft
enlorik wants to merge 1 commit into
Draft
Conversation
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed POST /forgot-password wasn't covered by the rate limit filter, so anyone could hammer it for email spam or account probing (POST /reset-password is also uncovered, but that's token consumption and deserves its own PR). Wired it into the existing bucket4j setup with its own bucket (5 submissions per 15 minutes per IP, included in the scheduled cleanup) and made the filter matching method-aware so only the POST is limited — the GET form page stays free, and login/register/verify-email behave exactly as before. Added config and filter tests for the new bucket, the 429 + Retry-After on the sixth request, and the GET bypass —
mvn testwent from 185 to 191 tests, all passing (0 failures, 0 errors).