security: store one-time token hashes instead of raw tokens#76
Draft
enlorik wants to merge 1 commit into
Draft
Conversation
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed the email-verification and password-reset tokens were sitting in the database in plain form, so anyone who got a copy of those tables could use every still-valid link. Now only a SHA-256 hash is persisted (new little TokenHasher component; the column keeps its old "token" name so the schema doesn't change) and the raw token only ever appears in the emailed link — incoming tokens get hashed before lookup, and expiry/used checks behave exactly as before. Deployment note: tokens issued before this change stop working once it ships, since we only have their raw value stored — they're short-lived and single-use anyway, so re-requesting a link covers it.
mvn testwent from 185 to 198 tests (new hasher vectors plus hash-vs-raw coverage in both token services), all passing.