Skip to content

fix: update zkemail report periods to align with grant-based quarters (not calendar quarters)#4

Closed
benceharomi wants to merge 1 commit intoensdao:mainfrom
zkemail:main
Closed

fix: update zkemail report periods to align with grant-based quarters (not calendar quarters)#4
benceharomi wants to merge 1 commit intoensdao:mainfrom
zkemail:main

Conversation

@benceharomi
Copy link
Copy Markdown

Summary

This PR corrects the quarterly report mapping for zkemail in providers.json.

Context

The Anti-Capture dashboard currently displays zkemail reports using standard calendar quarters:

  • Q1 → 2025/Q1
  • Q2 → 2025/Q2
  • Q3 → 2025/Q3

However, zkemail tracks reporting periods based on the grant start date, not calendar quarters.

Changes

Updated the mappings to reflect the correct reporting periods:

  • Q1 → 2025/Q3
  • Q2 → 2025/Q4
  • Q3 → 2026/Q1

Reason

This ensures consistency between zkemail's internal reporting schedule and what is displayed on the dashboard.

Impact

  • Fixes incorrect report placement in the UI
  • Prevents confusion for reviewers and stakeholders

Notes

No functional changes beyond correcting the displayed quarter mappings.

@alextnetto
Copy link
Copy Markdown
Collaborator

Hey @benceharomi, thanks for the PR! We need to keep the standard between all service providers, independent of the internal reporting, so it's legible for everyone. That's why having the quarters based on calendar is necessary.

Will close the PR, lmk your thoughts and if you have other suggestions.

@alextnetto alextnetto closed this Apr 28, 2026
@benceharomi
Copy link
Copy Markdown
Author

Hey @alextnetto , I understand wanting to keep things consistent across providers, but the current dashboard shows our reports as OVERDUE even though we submitted them.

Our grant started in Q3 2025, so our first report covers Q3, not Q1. Since the labels currently start from Q1, everything is shifted and the dashboard thinks we're behind.

Would you be open to either relabeling our reports to match the quarters they actually cover (which is what this PR does), or alternatively fixing the overdue markers so it's clear we hit our deadlines? Happy to work with whatever approach works best for the repo.

I also added our Q4 report to our fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants