ESB-245 - fetch root page dynamically instead of hardcoding 'homepage'#1609
Open
ffalqui wants to merge 3 commits intorelease/7.5from
Open
ESB-245 - fetch root page dynamically instead of hardcoding 'homepage'#1609ffalqui wants to merge 3 commits intorelease/7.5from
ffalqui wants to merge 3 commits intorelease/7.5from
Conversation
Add new Redux slice (SET_ROOT_PAGE) to store the root page code fetched from GET /api/pages/utils/root. Replace all HOMEPAGE_CODE references in selectors, actions, page tree, and vertical menu with the dynamic value. Expose rootPageCode via window.entando.globals for MFE menu consumption.
|
Requested publication of version |
MEM2677
reviewed
Feb 18, 2026
src/state/pages/actions.js
Outdated
| getPage(pageCode).then(response => resolve(response.ok)).catch(() => resolve(false)); | ||
| }); | ||
|
|
||
| let rootPageFetched = false; |
Member
There was a problem hiding this comment.
Controllare se lasciare questo stato fuori da redux comporta problemi quando lo stato viene resettato (la variabile rimane a true impedendo un nuovo fetch)
Author
There was a problem hiding this comment.
ho rimosso il check per il fetch tramite variabile
MEM2677
reviewed
Feb 18, 2026
src/state/pages/actions.js
Outdated
|
|
||
| let rootPageFetched = false; | ||
|
|
||
| export const fetchRootPage = () => async (dispatch) => { |
Member
There was a problem hiding this comment.
Siamo certi che nessuna azione che usi la root registrata nello stato sia chiamata prima o durante l'esecuzione di questa funzione? Altrimenti potrebbero usare un fallback che poi verrebbe sostituito dal risultato vero di questa fetch.
…h/group/free - Add test for new GET /pages/utils/root endpoint - Use dynamic rootPageCode in NavigationBarConfigFormContainer instead of hardcoded HOMEPAGE_CODE - Change PageTree rootPageCode defaultProp to null
|
Requested publication of version |
|
Requested publication of version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new Redux slice (SET_ROOT_PAGE) to store the root page code fetched from GET /api/pages/utils/root.
Replace all HOMEPAGE_CODE references in selectors, actions, page tree, and vertical menu with the dynamic value.
Expose rootPageCode via window.entando.globals for MFE menu consumption.
BREAKING CHANGE: page utility APIs moved under /api/pages/utils/: