Skip to content

ESB-971 - Fix private Node.js PATH filtering on Windows (Git Bash) #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ffalqui wants to merge 1 commit into from
Closed

ESB-971 - Fix private Node.js PATH filtering on Windows (Git Bash) #197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions src/services/process-executor-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,13 +215,20 @@ function setUpProcess(options: ProcessExecutionOptions) {
*/
function buildChildEnvironment(options: ProcessExecutionOptions) {
if (SHOULD_HIDE_PRIVATE_NODEJS) {
let privateNodeDir = path.dirname(process.execPath).replace(/\/bin$/, '');
privateNodeDir=privateNodeDir.endsWith('/') ? privateNodeDir : `${privateNodeDir}/`
let privateNodeDir = path.dirname(process.execPath).replace(/[/\\]bin$/, '');
// Normalize to forward slashes for consistent matching (Git Bash on Windows uses POSIX paths)
const normalizedPrivateDir = privateNodeDir.replace(/\\/g, '/');
const currentPath = (options.env || process.env).PATH || '';
// Support both ":" (POSIX/Git Bash) and ";" (native Windows) delimiters
const delimiter = currentPath.includes(';') ? ';' : ':';
const cleanedPath = currentPath
.split(path.delimiter)
.filter(p => !p.startsWith(privateNodeDir))
.join(path.delimiter);
.split(delimiter)
.filter(p => {
const normalizedEntry = p.replace(/\\/g, '/');
return !normalizedEntry.startsWith(normalizedPrivateDir + '/') &&
normalizedEntry !== normalizedPrivateDir;
})
.join(delimiter);
return { ...options.env, PATH: cleanedPath };
}

Expand Down
Loading