fix: resolve unsafe nightly backfill window from invalid env values#213
Open
RealDiligent wants to merge 1 commit into
Open
fix: resolve unsafe nightly backfill window from invalid env values#213RealDiligent wants to merge 1 commit into
RealDiligent wants to merge 1 commit into
Conversation
Author
|
CI workflows are in \�ction_required\ because this PR comes from a fork and needs maintainer approval to run.\n\nLocal validation is already green:\n- npm run lint\n- npm run build\n- npm test\n\nAfter workflow approval, checks should execute normally. |
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
RepoBackfillScheduleService parsed NIGHTLY_BACKFILL_DAYS with raw Number(...) and used it directly for nightly backfill jobs. Invalid/non-finite or out-of-range values could cause excessive or malformed backfill windows and unnecessary load across GitHub API, queue workers, and DB.
Fix approach
Impact
Risk / tradeoffs
Made with Cursor