refactor(common): extract shared LoadingCard component#1272
Open
fansilas wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a shared
<LoadingCard>component atsrc/components/common/LoadingCard.tsxto replace the inline<Card sx={{ p: 4, textAlign: 'center' }} elevation={0}>+<CircularProgress>pattern that was duplicated across several loading states.The component accepts an optional
size(defaults to 40) and an optionalsxthat merges over the base Card styles, so callers with custom backgrounds or borders can still use it.Replaced inline usages:
src/components/miners/MinerIdentityRail.tsx(size 32)src/components/miners/MinerOpenDiscoveryIssuesByRepo.tsxsrc/components/miners/MinerPRsTable.tsxsrc/components/prs/PRDetailsCard.tsx(custom sx forwarded for background and border)Sites that wrap the spinner in a
<Box>rather than a<Card>are a different layout (centered spinner in a flex container, no card chrome) and were intentionally left alone. The twoRepositoryPRsTable/RepositoryIssuesTableloading states render a section header alongside the spinner, so they do not match the spinner-only<LoadingCard>contract and were also left as is to preserve current behavior.Related Issues
N/A
Type of Change
Screenshots
No visual change is expected: the spinner renders at the same size, position, and color on every replaced site.
Checklist
npm run formatandnpm run lint:fixhave been runnpm run buildpasses