refactor(utils): extract route URL builders into shared paths.ts#1273
Open
fansilas wants to merge 1 commit into
Open
refactor(utils): extract route URL builders into shared paths.ts#1273fansilas wants to merge 1 commit into
fansilas wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR detail (
/miners/pr?repo=&number=) and repository detail (/miners/repository?name=) URLs were being hand-built in 14 places across the app, each with its ownencodeURIComponentboilerplate. This PR introducessrc/utils/paths.tsexposing two helpers,minerPrPathandminerRepositoryPath, and routes every existing call site through them. Output is byte-identical to the previous inline strings (param order, encoding, and casing all preserved), so navigation behaviour is unchanged.Two pre-existing oddities surfaced during the sweep. Both are left inline with a TODO and intentionally excluded from this PR so the extraction stays a no-op:
src/pages/HomePage.tsxlinks to/repositories/details?repo=..., which is not a registered route insrc/routes.tsx(only/miners/repositoryexists). Looks like a latent 404 bug rather than a second route variant.src/pages/dashboard/views/LiveCommitLog.tsxbuilds the PR href withoutencodeURIComponent, so adopting the helper would change the URL string. Worth converting in a follow-up.Related Issues
N/A
Type of Change
Screenshots
Not applicable. No rendered UI changes; only the internal source of route href strings is moving.
Checklist
npm run formatandnpm run lint:fixhave been runnpm run buildpasses