fix(validator): realign persisted scores to metagraph size on load_state#1607
Open
RealDiligent wants to merge 4 commits into
Open
fix(validator): realign persisted scores to metagraph size on load_state#1607RealDiligent wants to merge 4 commits into
RealDiligent wants to merge 4 commits into
Conversation
Author
|
CI validated on fork (964 tests passed, lint/pyright clean): https://github.com/RealDiligent/gittensor/actions/runs/28982027511 https://github.com/RealDiligent/gittensor/actions/runs/28982026612 |
RealDiligent
force-pushed
the
fix/critical-issue-state-metagraph-align
branch
from
d28d21f to
5cefb4b
Compare
load_state() restored scores/hotkeys from state.npz without resizing to the current metagraph.n, causing IndexError or misaligned on-chain weights after subnet growth or shrink. Realign persisted scores on load and consolidate metagraph resize handling in resync_metagraph(). Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1606
Summary
Realigns persisted validator
scores/hotkeysto the live metagraph onload_state()andresync_metagraph(), preventingIndexErrorcrashes and misaligned on-chain weights after subnet resize + restart.Root cause
load_state()restored rawstate.npzarrays without validatinglen(scores) == metagraph.n. Runtimeresync_metagraph()only padded on growth and never truncated on shrink.Fix approach
_align_scores_to_metagraph()to resize scores, preserve overlapping prefix, and zero slots where persisted hotkey != current metagraph hotkeyload_state()andresync_metagraph()self.hotkeysfrom live metagraph after load (not stale persisted list)Impact
Validators survive routine subnet resize/restart without crashing or emitting misaligned weights.
Risk / tradeoffs
Test plan
tests/validator/test_validator_state_alignment.py(grow, shrink, hotkey replacement, load_state)test(2026-07-15)