Skip to content

Fix #1636: allow null base_ref in OSS mirror merged-PR scoring #1641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marktech0813 wants to merge 1 commit into
base: test
Choose a base branch
from
Open

Fix #1636: allow null base_ref in OSS mirror merged-PR scoring #1641

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions gittensor/validator/oss_contributions/mirror/scoring.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,8 +213,9 @@ def check_merged_branch_eligibility(
additional = repo_config.additional_acceptable_branches or []
acceptable = [default_branch or 'main'] + additional

# base_ref check.
if not branch_matches_pattern(base_ref or '', acceptable):
# base_ref check — missing base_ref is pre-backfill / older mirror data; fall
# through like issue discovery rather than false-positive-rejecting the PR.
if base_ref is not None and not branch_matches_pattern(base_ref, acceptable):
return True, (f'PR #{pr_number} merged to {base_ref!r} not in acceptable branches={acceptable}')

# head_ref check — block PRs whose source branch is itself an acceptable
Expand Down Expand Up @@ -252,7 +253,8 @@ def _should_skip_merged_mirror_pr(scored: ScoredPR, repo_config: RepositoryConfi
When the mirror response is missing a field (older data predating the
schema additions), some checks fall through rather than false-positive-
blocking. Concretely: missing ``head_ref`` or ``head_repo_full_name`` skips
the head_ref check. Missing ``default_branch`` falls back to ``main``.
the head_ref check. Missing ``base_ref`` skips the base_ref check (pre-backfill
rows). Missing ``default_branch`` falls back to ``main``.
"""
pr = scored.pr

Expand Down