Add NetexId one-line utility like NetexIdUtils by skjolber · Pull Request #242 · entur/netex-utils

skjolber · 2026-03-20T22:48:30Z

Leave legacy class as-is, implement a faster 1-1 substitute based on existing parsers/validators/etc.

TODO: Too conservative to keep all legacy behaviour?

Copilot

Pull request overview

Adds a new no.entur.abt.netex.id.NetexId static facade intended to be a faster, legacy-shaped one-liner API built on the existing validator/parser internals, and updates documentation and benchmarks accordingly.

Changes:

Introduces NetexId facade with one-line helpers for create/derive/validate/extract operations.
Adds DefaultNetexIdValidator.validateToValueIndex(...) to support fast value-part replacement without regex/splitting.
Adds unit tests, a new JMH benchmark, and README documentation + updated benchmark results.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
`src/main/java/no/entur/abt/netex/id/NetexId.java`	New modern static facade wrapping existing validator/parser behavior.
`src/main/java/no/entur/abt/netex/id/DefaultNetexIdValidator.java`	Adds `validateToValueIndex` helper used by the facade for fast derivation.
`src/test/java/no/entur/abt/netex/id/NetexIdTest.java`	Adds unit tests for the new facade API behavior.
`src/test/java/no/entur/abt/netex/id/DefaultNetexIdValidatorTest.java`	Adds tests for `validateToValueIndex`.
`src/test/perf/no/entur/abt/netex/id/jmh/NetexIdFacadeBenchmark.java`	New JMH benchmark comparing facade vs legacy `NetexIdUtils`.
`src/test/perf/no/entur/abt/netex/id/jmh/BenchmarkMain.java`	Includes the new facade benchmark in the benchmark runner.
`README.md`	Documents the new facade and updates performance section/results.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-20T23:14:03Z

@skjolber I've opened a new pull request, #243, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Initial plan * Add null check for valuePart in NetexId.createFrom Co-authored-by: skjolber <1031478+skjolber@users.noreply.github.com> Agent-Logs-Url: https://github.com/entur/netex-utils/sessions/3f77131e-18b7-42cd-ac26-f9e31c020c12 --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: skjolber <1031478+skjolber@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

….java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot · 2026-03-20T23:34:21Z

@skjolber I've opened a new pull request, #245, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Initial plan * Fix test method name to follow consistent naming convention Co-authored-by: skjolber <1031478+skjolber@users.noreply.github.com> Agent-Logs-Url: https://github.com/entur/netex-utils/sessions/c651361f-f48d-4c62-ae7a-251da51332f9 --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: skjolber <1031478+skjolber@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

erlendnils1

I can't see any reason why we would want to keep the legacy behavior? If this is worth doing we should replace the existing impl (while keeping the existing api)

erlendnils1 · 2026-03-23T08:54:43Z

 				&& validateValue(string, last + 1, string.length());
 	}

+	public int validateToValueIndex(CharSequence string) {


erlendnils1 · 2026-03-23T08:57:25Z

+ */
+
+/**
+ * Modern utility facade with legacy-like one-liner methods.


Comment is a bit confusing? Should it at least describe the purpose of the class before describing modern/legacy?

skjolber added 3 commits March 20, 2026 23:48

Add NetexId one-line utility like NetexIdUtils

89ce82a

Add tests

f9922be

Merge branch 'main' into netexIdUtilEquivalent

361f988

skjolber requested a review from Copilot March 20, 2026 22:59

Copilot started reviewing on behalf of skjolber March 20, 2026 23:00 View session

Copilot AI reviewed Mar 20, 2026

View reviewed changes

Comment thread src/main/java/no/entur/abt/netex/id/NetexId.java

Comment thread src/main/java/no/entur/abt/netex/id/NetexId.java

Copilot AI mentioned this pull request Mar 20, 2026

Guard NetexId.createFrom against null valuePart #243

Merged

skjolber and others added 2 commits March 21, 2026 00:16

Update src/main/java/no/entur/abt/netex/id/NetexId.java

4ef4cf5

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

skjolber requested a review from Copilot March 20, 2026 23:28

Copilot started reviewing on behalf of skjolber March 20, 2026 23:28 View session

Copilot AI reviewed Mar 20, 2026

View reviewed changes

Comment thread src/test/perf/no/entur/abt/netex/id/jmh/NetexIdFacadeBenchmark.java Outdated

Comment thread src/main/java/no/entur/abt/netex/id/DefaultNetexIdValidator.java Outdated

Comment thread src/test/java/no/entur/abt/netex/id/NetexIdTest.java

Update src/test/perf/no/entur/abt/netex/id/jmh/NetexIdFacadeBenchmark…

cbe6ec0

….java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI mentioned this pull request Mar 20, 2026

Fix inconsistent test method naming in NetexIdTest #245

Merged

skjolber and others added 2 commits March 21, 2026 00:34

Update src/main/java/no/entur/abt/netex/id/DefaultNetexIdValidator.java

b95bdcc

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

skjolber requested a review from Copilot March 20, 2026 23:44

Copilot started reviewing on behalf of skjolber March 20, 2026 23:44 View session

Copilot AI reviewed Mar 20, 2026

View reviewed changes

Comment thread src/test/perf/no/entur/abt/netex/id/jmh/NetexIdFacadeBenchmark.java

Comment thread src/test/java/no/entur/abt/netex/id/NetexIdTest.java

skjolber requested a review from a team March 20, 2026 23:55

erlendnils1 reviewed Mar 23, 2026

View reviewed changes

skjolber added 2 commits April 14, 2026 19:06

Merge branch 'main' into netexIdUtilEquivalent

237d363

Merge branch 'main' into netexIdUtilEquivalent

39bf7c6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add NetexId one-line utility like NetexIdUtils#242

Add NetexId one-line utility like NetexIdUtils#242
skjolber wants to merge 10 commits intomainfrom
netexIdUtilEquivalent

skjolber commented Mar 20, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Mar 20, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Mar 20, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

erlendnils1 left a comment

Uh oh!

erlendnils1 Mar 23, 2026

Uh oh!

erlendnils1 Mar 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

skjolber commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Mar 20, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Mar 20, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

erlendnils1 left a comment

Choose a reason for hiding this comment

Uh oh!

erlendnils1 Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

erlendnils1 Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

skjolber commented Mar 20, 2026 •

edited

Loading