Conversation
skjolber
commented
May 4, 2026
skjolber
commented
May 4, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens NeTEx ID handling around predicates/builders/parsers, adds regression and branch-coverage tests, and introduces a repository skill file for Java development guidance.
Changes:
- Fixes predicate null-handling/exception paths and aligns a few public messages/constants/API signatures.
- Adds builder/parser conveniences such as building from an existing ID and seeding string interning from a broader collection type.
- Expands unit tests across predicates, validators, parsers, and builders; adds a
java-developerskill document.
Reviewed changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
src/test/java/no/entur/abt/netex/id/predicate/NetexIdPredicateBuilderTest.java |
Adds predicate-builder regression tests for null handling and empty builder state. |
src/test/java/no/entur/abt/netex/id/predicate/NetexIdCodespaceTypePredicateTest.java |
Adds predicate-focused branch/exception tests. |
src/test/java/no/entur/abt/netex/id/NetexIdValidatingParserTest.java |
Adds validating parser coverage for invalid codespace parsing. |
src/test/java/no/entur/abt/netex/id/NetexIdParserBuilderTest.java |
Adds parser-builder coverage for seeded interning with a collection input. |
src/test/java/no/entur/abt/netex/id/NetexIdNonValidatingBuilderTest.java |
Adds happy-path tests for building from an existing ID template. |
src/test/java/no/entur/abt/netex/id/NetexIdBuilderTest.java |
Adds validating-builder tests for null/invalid template IDs. |
src/test/java/no/entur/abt/netex/id/DefaultNetexIdValidatorTest.java |
Expands validator branch coverage for null, casing, digits, offsets, and malformed IDs. |
src/main/java/no/entur/abt/netex/id/predicate/NetexIdTypeValidatingPredicate.java |
Refactors validating type predicate exception flow. |
src/main/java/no/entur/abt/netex/id/predicate/NetexIdTypePredicate.java |
Adds null short-circuiting for non-validating type predicate. |
src/main/java/no/entur/abt/netex/id/predicate/NetexIdPredicateBuilder.java |
Updates type validation error text. |
src/main/java/no/entur/abt/netex/id/predicate/NetexIdCodespaceValidatingPredicate.java |
Refactors validating codespace predicate exception flow. |
src/main/java/no/entur/abt/netex/id/predicate/NetexIdCodespaceTypeValidatingPredicate.java |
Refactors validating codespace+type predicate exception flow. |
src/main/java/no/entur/abt/netex/id/predicate/NetexIdCodespaceTypePredicate.java |
Adds null short-circuiting for non-validating codespace+type predicate. |
src/main/java/no/entur/abt/netex/id/predicate/NetexIdCodespacePredicate.java |
Fixes predicate Javadoc wording. |
src/main/java/no/entur/abt/netex/id/NetexIdValidator.java |
Documents the deprecated offset-based validate overload. |
src/main/java/no/entur/abt/netex/id/NetexIdTypes.java |
Deprecates a typoed constant and adds the corrected alias. |
src/main/java/no/entur/abt/netex/id/NetexIdParserBuilder.java |
Broadens interning-seed API from Set to Collection and updates docs. |
src/main/java/no/entur/abt/netex/id/NetexIdNonValidatingBuilder.java |
Adds template-based builder construction from an existing ID. |
src/main/java/no/entur/abt/netex/id/InterningNetexIdParser.java |
Switches the interning cache to ConcurrentHashMap and simplifies insertion logic. |
.github/skills/java-developer/SKILL.md |
Adds project-specific Java development guidance for the repository skill system. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
… tests Agent-Logs-Url: https://github.com/entur/netex-utils/sessions/04217e4e-fea3-481d-b30f-5c9402e3be45 Co-authored-by: skjolber <1031478+skjolber@users.noreply.github.com>
…add null predicate tests Agent-Logs-Url: https://github.com/entur/netex-utils/sessions/7c46646c-cbdd-4b39-98c9-aebe97c6d474 Co-authored-by: skjolber <1031478+skjolber@users.noreply.github.com>
# Conflicts: # src/main/java/no/entur/abt/netex/id/InterningNetexIdParser.java Co-authored-by: skjolber <1031478+skjolber@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 21 out of 21 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
skjolber
commented
May 5, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 21 out of 21 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
skjolber
changed the title
erlendnils1
approved these changes
May 5, 2026
skjolber
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should be 100% test coverage for package
no.entur.abt.netex.idandno.entur.abt.netex.id.predicate.Merge this branch last.