external-events: migrate dossier to split register/ingest ABI#2
Merged
Conversation
Contributor
Author
|
Follow-up cleanup applied for replay context naming consistency in external-events flow. Changes in this PR branch:
Scope was limited to direct string references in Verification run:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ownables/dossieroff legacy external-event ABI to split runtime ABI exports:ownable_external_eventwithownable_register,ownable_ingest, andownable_encode_public_eventdossiercontract interfaces fromregister_external_event(ExternalEventMsg, ...)to:register(RegisterPublicEventMsg)ingest(IngestEventMsg)registerevent payload bytes.register_public_event_msg.jsoningest_event_msg.jsonencode_public_event_msg.jsonregister_handler, including instantiate/lock setup and unlocked state verificationCanonical Plan
/home/arnold/Projects/eqty/.runs/2026-05-23_18-38-53_external-events/plans/ownables-js.mdVerification
cargo test -qinownables/dossierpassed, 6 testscargo run --example schemainownables/dossierpassedyarn lintpassedyarn typecheckpassedyarn testpassed, 34 files / 285 testsPR Scope
feat/public-eventsownables/dossier; wallet/mobile files are excluded from the review surface.Temporary Dependencies
Upstream Version Replacement Dependency
Remaining Risks / Follow-up
dossiercurrently returnsNotImplementedforingest; this is intentional for current contract behavior and now has explicit coverage.