Skip to content

feat: rulebook standard structuring support#75

Merged
captjt merged 8 commits intomainfrom
feat/catalog-restructure
Dec 8, 2025
Merged

feat: rulebook standard structuring support#75
captjt merged 8 commits intomainfrom
feat/catalog-restructure

Conversation

@captjt
Copy link
Contributor

@captjt captjt commented Dec 8, 2025

No description provided.

@captjt captjt self-assigned this Dec 8, 2025
@captjt captjt requested review from backnotprop and Copilot December 8, 2025 16:55
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the catalog bundle structure to simplify the organization and reduce nesting. The main change moves from a per-harness system directory structure to a single shared system entrypoint at the rulebook root, and flattens the policy directory structure.

Key changes:

  • System entrypoint moved from policies/<harness>/system/ to system/ at rulebook root
  • Policies now placed directly in policies/<harness>/ instead of nested subdirectories
  • Updated namespace patterns to reflect the flatter structure

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
docs/docs/catalog/reference/namespace-conventions.md Updated documentation to reflect new namespace patterns with system at root and simplified policy structure
docs/docs/catalog/reference/cli.md Updated CLI validation checks to reflect system directory at root level
docs/docs/catalog/authoring/publishing.md Updated directory structure example to show system at root
docs/docs/catalog/authoring/policies.md Updated policy authoring guide with new namespace patterns and aggregation approach
docs/docs/catalog/authoring/manifest.md Updated manifest validation requirements for new structure
docs/docs/catalog/authoring/index.md Updated quick start guide and directory structure examples
cupcake-core/src/engine/catalog_overlay.rs Added system directory scanning and parsing logic at rulebook root
cupcake-cli/src/catalog_cli.rs Updated linting logic to validate new structure and namespace patterns

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@captjt captjt marked this pull request as draft December 8, 2025 17:27
@captjt captjt changed the title feat: slim down catalog bundle structure feat: rulebook standard structuring support Dec 8, 2025
@captjt captjt marked this pull request as ready for review December 8, 2025 18:27
@captjt captjt requested a review from Copilot December 8, 2025 18:27
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 23 out of 26 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

assert!(cupcake_dir.is_dir(), ".cupcake should be a directory");

// Verify all required subdirectories exist (only claude harness)
// New structure: system/ and helpers/ at root level, not per-harness
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should probably remove comments like these

@captjt captjt merged commit 7273af4 into main Dec 8, 2025
4 checks passed
@captjt captjt deleted the feat/catalog-restructure branch December 8, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants