refactor(validator): make pathfinder-validator an optional dependency#3344
Merged
refactor(validator): make pathfinder-validator an optional dependency#3344
pathfinder-validator an optional dependency#3344Conversation
t00ts
force-pushed
the
t00ts/refactor-p2p-consensus
branch
2 times, most recently
from
1ecf840 to
9263abe
Compare
Contributor
|
@t00ts wrt |
CHr15F0x
reviewed
Apr 16, 2026
CHr15F0x
approved these changes
Apr 16, 2026
t00ts
force-pushed
the
t00ts/refactor-p2p-consensus
branch
from
9263abe to
0665920
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This comment brought me down the rabbit hole of our
p2pflag in pathfinder and how we had structured our code around it.The
consensusmodule wasn't being guarded behind this flag, and it only makes sense that it is (consensus is just relevant in p2p context). So I propose we change this. I only had to moveConsensusChannelsout of theconsensusmodule (since sync code needs it, regardless of p2p).Also gated
devnet- @CHr15F0x correct me if this should not be the case, but I think it's just p2p testing infra.So
pathfinder-validatoris now optional, just aspathfinder-consensusis.Also, back to the initial comment,
skip_validationno longer needs its own feature guard, as the crate itself acts as the gate.