feat(rpc): populate block_number on pre-confirmed/pre-latest events#3348
Merged
zvolin merged 1 commit intoequilibriumco:mainfrom Apr 17, 2026
Merged
Conversation
…n starknet_getEvents
zvolin
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
block_numberon events returned from pre-confirmed and pre-latest blocks instarknet_getEvents. Previously these were alwaysnull, even though the speculative block number is known. This broke event parsers that expectblock_numberto always be present.block_hashremainsnullfor pending events as it is genuinely unknown.Resolves #3347
Details
match_and_fill_eventsnow accepts ablock_number: BlockNumberparameter and setsblock_number: Some(block_number)on constructed events. The three call sites inget_pending_eventspass the appropriate block number:pre_latest_block.numberfor pre-latest eventspending.pre_confirmed_block_number()for pre-confirmed events