Open
Conversation
eivindjahren
force-pushed
the
add_more_tests_for_grid
branch
6 times, most recently
from
c8ea960 to
cff9fdd
Compare
eivindjahren
force-pushed
the
add_more_tests_for_grid
branch
2 times, most recently
from
6434f16 to
804a4de
Compare
This is to make it easier to do cpp style memory handling. Also updates all the lib/tests code to use the new definitions.
The hostnum map is one based as witnessed by the following: 1. (line 1927): int host_index = hostnum[i] - 1; 2. (line 824) — same concept in different file format: rd_kw_iset_int(coords_kw, 5, cell->host_cell + 1); 3. (line 1508): cell->host_cell = coords[5] - 1; 4. (line 1473): comment uses 0 as sentinel which implies 1-based
eivindjahren
force-pushed
the
add_more_tests_for_grid
branch
from
804a4de to
37bb585
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.