Merged
Conversation
Contributor
julieh11
commented
Jul 9, 2025
julieh11
commented
- margins of error for the region of interest found by the feature detector can be adjusted with the input decks
- updated np.int0 for np.intp (deprecated)
- new sanity checks for results from the feature detector
- data type is now inferred from config["other"]["extraoptions"]["spectype"], as opposed to config["data"]["background"]["type"]
- references to the feature detector in the input and test decks are updated
- handling for both simultaneous analysis of EPW and IAW
- combined analysis finds IAW t0 shift
- simplification of feature detection analysis
- Implementation of morphological opening to handle noisy data
…into tsadar_automation
…blue shifted epw correctly
almilder
reviewed
Jul 15, 2025
Collaborator
There was a problem hiding this comment.
Lets chat about which of these changes we want to merge, I think we need some from both versions.
almilder
reviewed
Jul 15, 2025
almilder
reviewed
Jul 15, 2025
almilder
reviewed
Jul 15, 2025
almilder
reviewed
Jul 15, 2025
Collaborator
There was a problem hiding this comment.
why are there two set of entries?
almilder
reviewed
Jul 15, 2025
almilder
reviewed
Jul 15, 2025
Collaborator
There was a problem hiding this comment.
lets clean up these if statements a bit
almilder
requested changes
Jul 15, 2025
Collaborator
almilder
left a comment
almilder
left a comment
There was a problem hiding this comment.
Just a few things that need to be cleaned up
almilder
reviewed
Jul 15, 2025
| x_end: 40 | ||
| x_start: 40 | ||
| y_end: 40 | ||
| y_start: 40 |
Collaborator
There was a problem hiding this comment.
Can we modify these names identifying what x and y are?
Contributor
Author
There was a problem hiding this comment.
It means the minimum and maximum of the points on the x and y axes of "the boxed region" found by the feature detector. I am open to changing them, what do you suggest we change them to?
…into tsadar_automation
… detector test, all tests pass!
almilder
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.