Skip to content

Working model of multi ion flows#97

Open
Soham919 wants to merge 39 commits intoergodicio:mainfrom
Soham919:multi-ion-flows
Open

Working model of multi ion flows#97
Soham919 wants to merge 39 commits intoergodicio:mainfrom
Soham919:multi-ion-flows

Conversation

@Soham919
Copy link
Copy Markdown

Main changes are incorporating as a parameter to be fit separately for each ion. Major files changed :

  • modules/ts_params.py
  • physics/form_factor.py
  • configs/inputs.yaml + defaults.yaml

Notes :

  • Based on old version of working code on nersc
  • pushed from the fork tsadar_copy based on older branch mlflow_fix_gpu

Soham919 and others added 30 commits April 22, 2025 16:25
Modified looping structure to allow for initialization based on full previous runs
- Updated defaults.yaml and inputs.yaml for 1D configurations, adjusting parameters for ion and electron fitting ranges, smoothing methods, and optimizer settings.
- Enhanced the base.py distribution function to support different smoothing types (butterworth and hanning).
- Modified fitter.py to validate input configurations and ensure proper ordering of lineout and fit ranges.
- Refactored loops.py to implement a new optimization loop using Optax, allowing for more flexible fitting routines.
- Introduced multirun_angular_optax function for batch processing of angular Thomson scattering data.
- Updated loss_function.py to store auxiliary values during loss computation.
- Adjusted evaluate_background.py and lineouts.py to improve background processing and lineout calculations.
- Cleaned up postprocess.py to streamline data processing after fitting.
Copy link
Copy Markdown
Collaborator

@almilder almilder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small cleanup stuff

Comment thread configs/1d/defaults.yaml
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this file from the PR, we would like to keep the main branch decks static

Comment thread configs/1d/inputs.yaml
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this file from the PR, we would like to keep the main branch decks static

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this file from the PR, we would like to keep the main branch decks static

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this file from the PR, we would like to keep the main branch decks static

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this file from the PR, we would like to keep the examples static too

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please remove the old code that has been commented out

# electron susceptibility
# calculating normilized phase velcoity(xi's) for electrons
xie = omgdop / (k * vTe) - ud / vTe
udr = ud - Va # drift velocity w.r.t different ions
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not look right, lets discuss

Comment thread nersc-gpu.sh
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let revert this file

Comment thread queue_job.sh
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this one

Comment thread run_tsadar.py
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants