fix(report): source honey.conf so persisted verdict/baseline settings apply - #9
Merged
Conversation
… apply report.sh became config-dependent when the verdict policy + suppression baseline landed (HONEY_VERDICT_FLOOR*, HONEY_TRUSTED_PATTERNS, HONEY_BASELINE), but it never sourced lib/load-config.sh. The Claude routine runs report.sh as a SEPARATE process from daily-cycle.sh, so a floor set in honey.conf was silently ignored by the authoritative OVERALL line — and daily-cycle (which does load the config) would disagree with report.sh's printed verdict. Source load-config.sh before baseline.sh so honey.conf applies standalone. env var > honey.conf > default, unchanged. (notify-cycle.sh already loads it; win/report.ps1 already calls Import-HoneyConfig.) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Real bug surfaced while wiring up the daily routine.
report.shprints the authoritativeOVERALLverdict and — since the verdict policy + baseline landed — depends onHONEY_VERDICT_FLOOR*/HONEY_TRUSTED_PATTERNS/HONEY_BASELINE. But it never sourcedlib/load-config.sh, so a floor persisted inhoney.confwas silently ignored when the Claude routine runsreport.shas its own process. Worse,daily-cycle.shdoes load the config, so its exit code could disagree with report.sh's printed OVERALL.Fix: source
load-config.shbeforebaseline.sh. Verified:report.shstandalone now appliesHONEY_VERDICT_FLOOR_TRUSTED=highfrom honey.conf (OVERALL: EXPOSED (65 review)).notify-cycle.shalready loaded it;win/report.ps1already callsImport-HoneyConfig. shellcheck clean.🤖 Generated with Claude Code