docs: correct schemes-field comment in websites.yml#15
Merged
Conversation
The schema header comment claimed schemes defaults to [https] if omitted,
but no default was ever implemented — playbooks/main.yml uses
`subelements('schemes')`, which hard-fails on entries missing the field.
Replace the aspirational text with `(required)` so readers don't believe
in a default that won't work.
Refs #11.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
ericcames
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #11.
The header comment in
playbooks/files/websites.ymlclaimed:But that default was never implemented —
playbooks/main.ymluseswebsites | subelements('schemes'), which hard-fails if any entry omits theschemesfield. Every entry has always declared it explicitly.Replace the aspirational text with
(required)so readers don't believe in a default that won't work.Files
playbooks/files/websites.yml— one comment line correctedCHANGELOG.md— entry under[Unreleased] / ChangedTest plan
yamllintclean locallyansible-lintclean locally🤖 Generated with Claude Code