CE: Per-page meta descriptions in page_shell#318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Every shell-rendered page (/signup, /login, /integrate, /setup, /dashboard, /checkout) currently emits the same generic meta description, og:description, and twitter:description. Google collapses identical descriptions and social shares look interchangeable, which hurts SERP CTR on the conversion-critical signup/login pages.
What
Adds a small private helper in
crates/modelrelay-web/src/templates.rsthat returns an intent-tuned description for known page titles (sign up, log in, integrate, setup, dashboard, checkout) and falls back to the existing generic line for unknown titles.page_shell_customnow uses it for the meta description, og:description, and twitter:description tags. No callsite changes — purely internal to the shell template.Verify
After merge + deploy:
curl -s https://modelrelay.io/signup | grep meta\ name=\"description\"→ distinctive Sign Up copycurl -s https://modelrelay.io/login | grep meta\ name=\"description\"→ distinctive Log In copycurl -s https://modelrelay.io/integrate | grep meta\ name=\"description\"→ distinctive Integrate copy/and/pricinguntouched (already have static unique descriptions)Test plan