scope ci push triggers to main#52
Merged
Merged
Conversation
An unscoped push trigger ran gitleaks twice on every pull request, once for the push to the PR branch and once for the pull_request event. Scope push to main so PR branches get exactly one run. Pre-merge coverage is unchanged. The required check "scan for secrets" is produced by the pull_request run, and main is still scanned on every push after a merge.
Mirrors the gitleaks change. Both ran twice on every pull request, once for the push to the PR branch and once for the pull_request event. Scope push to main so each runs once per PR. The required contexts all report from the pull_request run, so merges are unaffected. A branches filter with no tags key means tag pushes no longer trigger these workflows, and neither one builds or publishes anything.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every workflow ran twice on each pull request, once for the push to the PR
branch and once for the pull_request event. Scoping the push trigger to main
in gitleaks, tests, and web leaves one run per PR, and main is still covered
on every push after a merge. Required checks are unaffected, since all four
contexts report from the pull_request run. Two deltas worth knowing: a branch
with no open PR is no longer scanned or tested until the PR opens, and tag
pushes no longer trigger these workflows (none of them build or publish).