[pull] main from vercel:main#351
Merged
Merged
Conversation
* [ci] Attribute backport changelog entries to original PR author `@changesets/changelog-github` resolves a changeset commit to its associated PR via the GitHub GraphQL `associatedPullRequests` field. For commits landed on `stable` via our backport workflow, that resolves to the backport PR authored by `github-actions[bot]` (since the backport workflow uses `createCommitOnBranch` to produce signed commits), so the generated changelog ends up with "Thanks @github-actions!" instead of the original contributor. This adds a small `.changeset/changelog.mjs` wrapper around `@changesets/changelog-github` that detects backport PRs by matching the title (`Backport #N: ...`) or body (`Automated backport of #N to ` + '`stable`' + `...`) produced by `.github/workflows/backport.yml`, resolves the original PR number, and injects `pr:`/`commit:` directives into the changeset summary before delegating to the upstream generator. The result is that the rendered changelog entry attributes the change to the original PR and author, while the commit link still points at the backport commit on the release branch. * Address review feedback - Use `Bearer` instead of `Token` for the GitHub GraphQL auth header for consistency with the rest of the repo (Copilot review on PR #2091). - Add a defensive `formatError` helper so `console.warn` in the catch blocks doesn't itself throw when a non-Error value is thrown (Copilot review on PR #2091).
Turborepo replays nextjs-turbopack:build from cache without restoring the Vercel diagnostics manifest (.vercel/output/diagnostics/workflows-manifest.json), which causes the Vercel deployment to fail post-build. Add .vercel/output/** to the workbench's Turbo outputs so it is persisted and replayed. Applies to both nextjs-turbopack and nextjs-webpack (whose turbo.json is a symlink).
* fix(world-local): tighten ID validation Forward-port of code review fixes from #1920 (backport of #1829): - Reject dots inside entity IDs in `assertSafeEntityId`. Internal IDs (ULIDs, step_N, etc.) never contain dots, but `stripTag()` / `getObjectCreatedAt()` strip a trailing `.[tag]` suffix from filenames, so a request-supplied runId like `wrun_123.foo` would be silently mangled during listing/pagination. - Reject empty `correlationId` on events that include one. The event schemas only require `z.string()`, so without this check a step_created / hook_created / wait_created request with `correlationId: ''` would silently be written under a malformed composite key like `${runId}-`. The streamer regression tests from #1920 are not forward-ported because main's streamer surface differs (renamed methods, separate test coverage) from stable's v4 shape. * simplify changeset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )