Skip to content

test(sec-10): add role-based authorization regression tests for trade…#227

Merged
ericmt-98 merged 2 commits into
ericmt-98:mainfrom
ZuLu0890:fix/sec-10-trade-auth-regression-tests
Jun 30, 2026
Merged

test(sec-10): add role-based authorization regression tests for trade…#227
ericmt-98 merged 2 commits into
ericmt-98:mainfrom
ZuLu0890:fix/sec-10-trade-auth-regression-tests

Conversation

@ZuLu0890

Copy link
Copy Markdown
Contributor

… state machine

  • Add micopay/backend/src/tests/tradeAuth.test.ts with 9 regression tests covering lockTrade (seller-only), revealTrade (seller-only), getTradeSecret (seller-only), completeTrade (buyer-only), and getTradeById (participants-only) guards
  • Add test:trade-auth npm script to micopay/backend/package.json
  • Add docs/security-reports/SEC-10-state-machine-regresion.md report

All 9 tests pass. tsc build is clean.
Closes #217

… state machine

- Add micopay/backend/src/tests/tradeAuth.test.ts with 9 regression tests
  covering lockTrade (seller-only), revealTrade (seller-only),
  getTradeSecret (seller-only), completeTrade (buyer-only), and
  getTradeById (participants-only) guards
- Add test:trade-auth npm script to micopay/backend/package.json
- Add docs/security-reports/SEC-10-state-machine-regresion.md report

All 9 tests pass. tsc build is clean.
Closes ericmt-98#217
@drips-wave

drips-wave Bot commented Jun 29, 2026

Copy link
Copy Markdown

@ZuLu0890 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@ericmt-98

Copy link
Copy Markdown
Owner

¡Gracias por el trabajo en SEC-10! 🙏

Aclaración de alcance: actualizamos esta issue de auditoría para que la entrega sea únicamente el reporte docs/security-reports/SEC-10-*.md. Los fixes los implementa el equipo internamente, para revisarlos y probarlos de forma controlada (varios PRs se solapan en los mismos archivos y generan conflictos).

¿Podrías ajustar este PR para que deje solo el reporte .md y quitar los cambios de código de la app/backend? Tu propuesta de arreglo es muy bienvenida — descríbela en la sección Sugerencia de fix del reporte. Conservamos tu crédito por el hallazgo.

Si prefieres, nos quedamos con tu reporte y movemos el código a un PR aparte. ¡Gracias!

@ericmt-98 ericmt-98 merged commit 1aaa35f into ericmt-98:main Jun 30, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[SEC-10] [Test de regresión] Autorización por rol en trade state machine

2 participants