docs(security): add SEC-24 trade state override audit report#294
Closed
attyolu wants to merge 2 commits into
Closed
docs(security): add SEC-24 trade state override audit report#294attyolu wants to merge 2 commits into
attyolu wants to merge 2 commits into
Conversation
Report-only for ericmt-98#256. Documents that getTradeStateDebugOverride() allows localStorage/query-string spoofing of the trade status badge in all builds (no env guard). Includes reproduction steps, affected pages, attack vectors, and fix suggestions.
|
@attyolu Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
ExploreMap.tsx accesses offer.online when building OfferConfirmData but the Offer interface lacked the property, causing TS2339 build errors on lines 221 and 284.
Owner
|
Merged manually (ExploreMap already has online? field from previous PRs) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
##closes #256
The report deliverable for SEC-24 is complete — the file SEC-24-trade-state-override.md is ready to submit as a PR or issue comment.
However, the underlying vulnerability is not fixed — and per the issue instructions, it shouldn't be. The issue explicitly states:
So to be clear on status:
import.meta.env.DEV, harden)The report is ready to deliver. You can submit it as a PR or paste it as a comment on issue #256.
Report-only for #256. Documents that getTradeStateDebugOverride() allows localStorage/query-string spoofing of the trade status badge in all builds (no env guard). Includes reproduction steps, affected pages, attack vectors, and fix suggestions.