feat(frontend): show total effective fee % + >5% guardrail on confirm…#296
Merged
ericmt-98 merged 1 commit intoJun 30, 2026
Conversation
…ation screen T-5 (ericmt-98#192) asked for the combined effective cost and a >5% warning on the provider card AND on the confirmation screen. The cards were covered; the post-map confirmation screen still only broke fees down in MXN without the combined effective percentage or the abandonment guardrail. - Add "Costo total efectivo" row = provider commission + platform fee, via the shared effectiveFeePercent() helper (no duplicated math). - Show a clear warning before the Confirmar button when the total exceeds the threshold (the ~5% ceiling from validations V-1/V-3/V-7/V-8). - Threshold is a configurable prop (maxEffectiveFeePercent, default MAX_EFFECTIVE_FEE_PERCENT) — not hardcoded in the component. tsc --noEmit passes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #192
#192 · T-5 — confirmation-screen completion
The card-level part of T-5 (effective total fee + >5% guardrail on the provider
cards) is already in
main. This PR finishes the remaining requirement from thetask: the confirmation screen (
pages/TradeConfirmation.tsx).Previously the confirmation screen broke fees down in MXN but never showed the
combined effective percentage the user actually pays, nor the abandonment
guardrail — the ~5% ceiling identified by validations V-1/V-3/V-7/V-8.
Changes (single file:
micopay/frontend/src/pages/TradeConfirmation.tsx)with the shared
effectiveFeePercent()helper (no duplicated math).maxEffectiveFeePercent, defaulting toMAX_EFFECTIVE_FEE_PERCENT) — not hardcoded.Acceptance criteria
tsc --noEmitpasses.Reuses the constant/helper already merged for the card-level work, so it stays
consistent with
ExploreMap/DepositMap.