Just renaming some files for Windows users#1
Open
ncsuWolfpack wants to merge 5 commits intoericnormand:masterfrom
Open
Just renaming some files for Windows users#1ncsuWolfpack wants to merge 5 commits intoericnormand:masterfrom
ncsuWolfpack wants to merge 5 commits intoericnormand:masterfrom
Conversation
…ill field names as strings lead to more bugs.js
… 238 Will first-class fields make the API hard to change.js
…are we wrapping the code in a function.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a few files with a question mark in them which fails to clone to Windows machines as it is a reserved character:
https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file#naming-conventions