SPM support — SimulatorPool bypass#45
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MutantExecutor.buildArtifactnow uses aswitchonprojectType. For.spm, it callsBuildStage.buildSPMand returns a realBuildArtifact(with nilxctestrunURL/plist), propagatingcompilationFailedif the build fails. For.xcode, existing behaviour is preserved (compilation failure returns nil, triggering per-file fallback).makePoolrequired no changes — SPM resolves toplatform=macOS, whichSimulatorManager.requiresSimulatorPoolcorrectly bypasses, creating a macOS slot pool with no simulator cloning.TestExecutionStageand are marked.unviablevia the nil-plist guard introduced in Phase 3, until Phase 5 implements SPM test execution.Type of Change
Invariants Checklist
xcodebuild build-for-testingruns exactly once for all schematizable mutantsschematizedContentnever contains the__swiftMutationTestingIDglobal declarationPipeline Impact
Which stages are affected?
Testing
ProcessLaunching— no realxcodebuild,xcrun simctl, orxcresulttoolFileHelpersfor any filesystem interaction (temp directories only)swift test)