Code and architecture revision#50
Merged
Merged
Conversation
…ove helpers to TestSupport
…ract FallbackExecutor
…for ExecutionDeps
…IncompatibleRewritingStage
…pdate SchematizationStageTests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three distinct bugs were fixed and an architectural refactor consolidated execution dependencies.
Fixes:
BuildStagenow useslaunchCapturinginstead oflaunch, making compilation errors visible on stderrswift build --build-tests --target Xare mutually exclusive in SPM; the correct flag is now chosen based on the presence of--targetBuildError.compilationFailedwas not caught in the SPM path ofbuildArtifact, crashing the CLI; it is now intercepted and triggers the incremental retry-with-exclusion flowPerformance:
swift test --skip-buildper mutantRefactor:
ExecutionDepsgroupsProcessLaunching,CacheStore,ProgressReporterandMutationCounter— eliminates long parameter lists inTestExecutionStage,IncompatibleMutantExecutorandFallbackExecutorMutantIndexingStage(assigns indices and determines schematizability),IncompatibleRewritingStage(rewrites incompatible mutants),SchematizationStage(schematizable mutants only)SchematizationResultremoved; pipeline stages return values directlyType of Change
Invariants Checklist
xcodebuild build-for-testingruns exactly once for all schematizable mutantsschematizedContentnever contains the__swiftMutationTestingIDglobal declarationPipeline Impact
Which stages are affected?
Testing
ProcessLaunching— no realxcodebuild,xcrun simctl, orxcresulttoolFileHelpersfor any filesystem interaction (temp directories only)swift test)