Adds QuantizeMultiple, which produces a palette for a slice of images#2
Open
carbocation wants to merge 5 commits intoericpauley:masterfrom
Open
Adds QuantizeMultiple, which produces a palette for a slice of images#2carbocation wants to merge 5 commits intoericpauley:masterfrom
carbocation wants to merge 5 commits intoericpauley:masterfrom
Conversation
an optimal palette across the set of images.
Owner
|
Thanks for the contribution, this definitely seems useful! This is perhaps a little pedantic, but could we modify the internal I can also try this change out sometime if you'd prefer not to bother with it. |
have the same size.
This addresses a personal need and is also responsive to ericpauley#3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted in #1 , for animated gifs, it is ideal to build a palette that is aware of all of the images that will contribute to the gif. This pull request adds
QuantizeMultiple, which ingests a slice of images rather than a single image. This preservesQuantizein order to prevent breaking the public API. It modifies the private API by changingbuildBucketMultipletobuildBucketand causing it to ingest a slice of images rather than just one.Visually/subjectively, this produces nicer appearing images for me than (a) applying Quantize either to every image separately, which can lead to palette jitter between frames, or (b) applying Quantize to just one key image and applying the palette to every image, which can lead to inappropriate coloration in some frames.