fix: print as PDF renders blank page

[jordanlee]

Summary

• Fix print as PDF rendering a blank page by using a dedicated preview window with proper content loading
• Improve print margins and page styling for clean PDF output
• Swap shortcuts: Cmd+P → command palette (standard), Cmd+Shift+P → print/export as PDF
• Block browser print dialog in preview mode
• Add print shortcut to Settings > Shortcuts reference

Test plan

• Print a note via Cmd+Shift+P — PDF renders with correct content and margins
• Cmd+P opens command palette in main app
• Cmd+P is blocked in preview mode (no browser print dialog)
• Verified with a clean (non-cached) build

🤖 Generated with Claude Code

Summary by CodeRabbit

Release Notes

• New Features

  • Added keyboard shortcut (Cmd/Ctrl+Shift+P) to print and export notes as PDF.

• Improvements

  • Enhanced print/PDF layout with optimized margins, width constraints, and page-break handling.
  • Improved table and editor styling for print output.
  • Better sidebar and toolbar visibility management in print view.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 380fa576-7cdd-4427-a447-3ca1cb212f6b

📥 Commits

Reviewing files that changed from the base of the PR and between 77d2963 and f4334d0.

📒 Files selected for processing (6)

• src/App.css
• src/App.tsx
• src/components/editor/Editor.tsx
• src/components/preview/PreviewApp.tsx
• src/lib/shortcuts.ts
• src/services/pdf.ts

💤 Files with no reviewable changes (1)

• src/services/pdf.ts

✅ Files skipped from review due to trivial changes (1)

• src/lib/shortcuts.ts

🚧 Files skipped from review as they are similar to previous changes (4)

• src/components/preview/PreviewApp.tsx
• src/App.tsx
• src/components/editor/Editor.tsx
• src/App.css

---

📝 Walkthrough

Walkthrough

This PR adjusts print/PDF layout through comprehensive CSS changes with page margins and width constraints, implements a Cmd/Ctrl+Shift+P keyboard shortcut for printing with custom event handling, modifies Cmd/Ctrl+P behavior to require Shift not pressed, and adds semantic data attributes to editor layout elements for print targeting.

Changes

Cohort / File(s)	Summary
Print Styling and Layout src/App.css	Comprehensive print/PDF layout adjustments including global @page margins, width constraints for editor containers, semantic selector updates for sidebar/toolbar hiding, table formatting rules, and page-break control modifications.
Keyboard Shortcut Implementation src/App.tsx, src/components/preview/PreviewApp.tsx, src/lib/shortcuts.ts	Added Cmd/Ctrl+Shift+P print shortcut with custom event dispatch, modified Cmd/Ctrl+P to require Shift not pressed, implemented cross-component event handling, and documented new shortcut in shortcut categories.
Editor Print Event Integration src/components/editor/Editor.tsx	Registered custom print-note event listener triggering PDF download, added semantic data attributes to layout containers (data-format-bar, data-editor-content-area, data-editor-scroll), and removed descriptive comments.
PDF Service Cleanup src/services/pdf.ts	Removed explanatory comments; core downloadPdf function behavior unchanged.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• Add native print export and customizable note names #32: Modifies the same print/export flow files (App.css, App.tsx, Editor.tsx, PreviewApp.tsx, pdf.ts) for print functionality coordination.
• feat: add keyboard shortcuts for duplicate, delete, and empty-note navigation #86: Both PRs modify global keyboard handling in App.tsx with custom event dispatching patterns for cross-component communication.
• feat: add interface zoom with keyboard shortcuts #47: Both PRs adjust keyboard shortcut handling in App.tsx and update App-level print/layout CSS rules.

Poem

🐰 A print shortcut hops into play,
Shift+P saves the day—
Custom events bound with care,
Semantic data attributes fair,
CSS margins align just right,
PDF exports in pristine sight! ✨📄

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix: print as PDF renders blank page' is highly specific and directly addresses the core issue being fixed. It matches the main objective of the PR.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/App.css`:
- Around line 1123-1125: Replace deprecated usage of "word-break: break-word" by
removing it or setting "word-break: normal" and rely on the existing
"overflow-wrap: break-word" to achieve the desired behavior; update every
occurrence (e.g., the block containing "overflow-wrap: break-word !important;"
and the adjacent "word-break: break-word !important;" as well as the similar
blocks around the other reported locations) so Stylelint no longer flags the
deprecated value.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 11e6c057-a739-4527-af83-f5ac38ce9ad7

📥 Commits

Reviewing files that changed from the base of the PR and between 90af978 and ed0c22f.

📒 Files selected for processing (5)

• src/App.css
• src/App.tsx
• src/components/editor/Editor.tsx
• src/components/preview/PreviewApp.tsx
• src/services/pdf.ts

🚧 Files skipped from review as they are similar to previous changes (2)

• src/App.tsx
• src/components/editor/Editor.tsx

[erictli]

@jordanlee - thanks for this fix (and for improving some of the existing code)! I resolved some conflicts with parallel PRs and removed the toast because I didn't feel it was necessary.