Skip to content

Hide all empty FinOps DataGrids to prevent scrollbar artifacts #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erikdarlingdata merged 1 commit into from
Mar 18, 2026
+7 −0
Merged

Hide all empty FinOps DataGrids to prevent scrollbar artifacts #620

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Dashboard/Controls/FinOpsContent.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ private async Task LoadRecommendationsAsync()
{
var data = await _databaseService.GetFinOpsRecommendationsAsync(_currentServerMonthlyCost);
RecommendationsDataGrid.ItemsSource = data;
RecommendationsDataGrid.Visibility = data.Count > 0 ? Visibility.Visible : Visibility.Collapsed;
RecommendationsNoDataMessage.Visibility = data.Count == 0 ? Visibility.Visible : Visibility.Collapsed;
RecommendationsCountIndicator.Text = data.Count > 0 ? $"{data.Count} recommendation(s)" : "";
}
Expand Down Expand Up @@ -366,6 +367,7 @@ private async Task LoadDatabaseResourcesAsync()
var hoursBack = GetResourceUsageHoursBack();
var data = await _databaseService.GetFinOpsDatabaseResourceUsageAsync(hoursBack);
DatabaseResourcesDataGrid.ItemsSource = data;
DatabaseResourcesDataGrid.Visibility = data.Count > 0 ? Visibility.Visible : Visibility.Collapsed;
DatabaseResourcesNoDataMessage.Visibility = data.Count == 0 ? Visibility.Visible : Visibility.Collapsed;
DbResourcesCountIndicator.Text = data.Count > 0 ? $"{data.Count} database(s)" : "";
}
Expand All @@ -387,6 +389,7 @@ private async Task LoadStorageGrowthAsync()
{
var data = await _databaseService.GetFinOpsStorageGrowthAsync();
StorageGrowthDataGrid.ItemsSource = data;
StorageGrowthDataGrid.Visibility = data.Count > 0 ? Visibility.Visible : Visibility.Collapsed;
StorageGrowthNoDataMessage.Visibility = data.Count == 0 ? Visibility.Visible : Visibility.Collapsed;
StorageGrowthCountIndicator.Text = data.Count > 0 ? $"{data.Count} database(s)" : "";
}
Expand Down Expand Up @@ -491,6 +494,7 @@ private async Task LoadWaitCategorySummaryAsync()
}

WaitCategorySummaryDataGrid.ItemsSource = data;
WaitCategorySummaryDataGrid.Visibility = data.Count > 0 ? Visibility.Visible : Visibility.Collapsed;
WaitCategorySummaryNoDataMessage.Visibility = data.Count == 0 ? Visibility.Visible : Visibility.Collapsed;
}
catch (Exception ex)
Expand Down Expand Up @@ -525,6 +529,7 @@ private async Task LoadExpensiveQueriesAsync()
}

ExpensiveQueriesDataGrid.ItemsSource = data;
ExpensiveQueriesDataGrid.Visibility = data.Count > 0 ? Visibility.Visible : Visibility.Collapsed;
ExpensiveQueriesNoDataMessage.Visibility = data.Count == 0 ? Visibility.Visible : Visibility.Collapsed;
ExpensiveQueriesCountIndicator.Text = data.Count > 0 ? $"{data.Count} query(s)" : "";
}
Expand All @@ -542,6 +547,7 @@ private async Task LoadMemoryGrantEfficiencyAsync()
{
var data = await _databaseService.GetFinOpsMemoryGrantEfficiencyAsync();
MemoryGrantEfficiencyDataGrid.ItemsSource = data;
MemoryGrantEfficiencyDataGrid.Visibility = data.Count > 0 ? Visibility.Visible : Visibility.Collapsed;
MemoryGrantEfficiencyNoDataMessage.Visibility = data.Count == 0 ? Visibility.Visible : Visibility.Collapsed;
}
catch (Exception ex)
Expand Down Expand Up @@ -765,6 +771,7 @@ private async Task LoadHighImpactQueriesAsync()
var hoursBack = GetHighImpactHoursBack();
var data = await _databaseService.GetFinOpsHighImpactQueriesAsync(hoursBack);
HighImpactDataGrid.ItemsSource = data;
HighImpactDataGrid.Visibility = data.Count > 0 ? Visibility.Visible : Visibility.Collapsed;
HighImpactNoDataMessage.Visibility = data.Count == 0 ? Visibility.Visible : Visibility.Collapsed;
HighImpactCountIndicator.Text = data.Count > 0 ? $"{data.Count} high-impact query(s)" : "";
}
Expand Down
Loading