Skip to content

Fix ObjectDisposedException crash in SetStatus (#105) #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erikdarlingdata merged 1 commit into from
Mar 18, 2026
Merged

Fix ObjectDisposedException crash in SetStatus (#105) #107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 9 additions & 14 deletions src/PlanViewer.App/Controls/QuerySessionControl.axaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,30 +322,25 @@ private string GetTextFromCursor()

private void SetStatus(string text, bool autoClear = true)
{
_statusClearCts?.Cancel();
_statusClearCts?.Dispose();
_statusClearCts = null; // ← prevent stale reference to a disposed CTS
var old = _statusClearCts;
_statusClearCts = null;
old?.Cancel();
old?.Dispose();

StatusText.Text = text;

if (autoClear && !string.IsNullOrEmpty(text))
{
_statusClearCts = new CancellationTokenSource();
var token = _statusClearCts.Token;
_ = Task.Delay(3000, token).ContinueWith(_ =>
var cts = new CancellationTokenSource();
_statusClearCts = cts;
_ = Task.Delay(3000, cts.Token).ContinueWith(_ =>
{
Avalonia.Threading.Dispatcher.UIThread.Post(() =>
{
StatusText.Text = "";
_statusClearCts = null; // ← also clear after natural expiry
});
Avalonia.Threading.Dispatcher.UIThread.Post(() => StatusText.Text = "");
}, TaskContinuationOptions.OnlyOnRanToCompletion);

}
}


private async void Connect_Click(object? sender, RoutedEventArgs e)
private async void Connect_Click(object? sender, RoutedEventArgs e)
{
await ShowConnectionDialogAsync();
}
Expand Down
Loading