v1.2.0 Release (with #105 crash fix)#108
Merged
erikdarlingdata merged 2 commits intomainfrom Mar 18, 2026
Merged
Conversation
The CTS disposal added in #97 could race with the 3-second Task.Delay continuation. If SetStatus was called again after the old CTS was disposed but before the continuation ran, Cancel() on the disposed CTS threw ObjectDisposedException, crashing the app. Fix: null out the field before Cancel/Dispose so the next call never touches the disposed instance. Closes #105 Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughRefactors cancellation token lifecycle management in the status auto-clear mechanism. The change reorders operations to capture the old CancellationTokenSource, clear the field reference, cancel and dispose the old token, then create and assign a new one. This eliminates overlapping cancellations and potential token reuse. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v1.2.0 Release
Re-release with crash fix for #105 (ObjectDisposedException in SetStatus when loading Query Store plans).
Query Store Enhancements
Bug Fixes
Code Quality (22 fixes)
🤖 Generated with Claude Code
Summary by CodeRabbit
Release Notes