Feature/query store grid barchart#109
Merged
erikdarlingdata merged 6 commits intoerikdarlingdata:devfrom Mar 18, 2026
Merged
Conversation
…rikdarlingdata#107) The CTS disposal added in erikdarlingdata#97 could race with the 3-second Task.Delay continuation. If SetStatus was called again after the old CTS was disposed but before the continuation ran, Cancel() on the disposed CTS threw ObjectDisposedException, crashing the app. Fix: null out the field before Cancel/Dispose so the next call never touches the disposed instance. Closes erikdarlingdata#105 Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes on the query store grid :
Which component(s) does this affect?
How was this tested?
Describe the testing you've done. Include:
Checklist
dotnet build -c Debug)dotnet test)Addenum
CherryPick you commit from PR#107