Skip to content

Problem with duplication of window name in IE #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rikanishu wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Problem with duplication of window name in IE #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
976cfa2
IE fix
Rikanishu Apr 15, 2015
bb2576b
IE fix
Rikanishu Apr 15, 2015
9510e4b
IE fix
Rikanishu Apr 15, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
node_modules
8 changes: 5 additions & 3 deletions dist/jquery.printelement.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/*! jQuery printElement - v2.0.1 - 2014-08-22
/*! jQuery printElement - v2.0.1 - 2015-04-15
* https://github.com/erikzaadi/jQuery.printElement
* Copyright (c) 2014 erikzaadi; Licensed MIT, GPL */
* Copyright (c) 2015 erikzaadi; Licensed MIT, GPL */
/*global window,focus,setTimeout,navigator*/
(function (window, undefined) {
var document = window.document;
Expand Down Expand Up @@ -53,7 +53,9 @@
var popupOrIframe = null;
var documentToWriteTo = null;
if (opts.printMode.toLowerCase() === 'popup') {
popupOrIframe = window.open('about:blank', 'printElementWindow', 'width=650,height=440,scrollbars=yes');
// IE duplication name bug: http://stackoverflow.com/questions/7146767/i-get-access-is-denied-when-i-try-to-print-a-page-using-jquery-printelement-js
var windowName = 'printElementWindow_' + (Math.round(Math.random() * 99999)).toString();
popupOrIframe = window.open('about:blank', windowName, 'width=650,height=440,scrollbars=yes');
documentToWriteTo = popupOrIframe.document;
} else {
//The random ID is to overcome a safari bug http://www.cjboco.com.sharedcopy.com/post.cfm/442dc92cd1c0ca10a5c35210b8166882.html
Expand Down
6 changes: 3 additions & 3 deletions dist/jquery.printelement.min.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "jquery.printElement",
"name": "jquery.printelement",
"title": "jQuery printElement",
"description": "The best jQuery plugin ever.",
"version": "2.0.1",
Expand Down
4 changes: 3 additions & 1 deletion src/jquery.printelement.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,9 @@
var popupOrIframe = null;
var documentToWriteTo = null;
if (opts.printMode.toLowerCase() === 'popup') {
popupOrIframe = window.open('about:blank', 'printElementWindow', 'width=650,height=440,scrollbars=yes');
// IE duplication name bug: http://stackoverflow.com/questions/7146767/i-get-access-is-denied-when-i-try-to-print-a-page-using-jquery-printelement-js
var windowName = 'printElementWindow_' + (Math.round(Math.random() * 99999)).toString();
popupOrIframe = window.open('about:blank', windowName, 'width=650,height=440,scrollbars=yes');
documentToWriteTo = popupOrIframe.document;
} else {
//The random ID is to overcome a safari bug http://www.cjboco.com.sharedcopy.com/post.cfm/442dc92cd1c0ca10a5c35210b8166882.html
Expand Down