fix oidcc_plug.gen.controller AuthHTML generation and its testing#79
Merged
maennchen merged 1 commit intoerlef:mainfrom Apr 9, 2026
Merged
fix oidcc_plug.gen.controller AuthHTML generation and its testing#79maennchen merged 1 commit intoerlef:mainfrom
maennchen merged 1 commit intoerlef:mainfrom
Conversation
maennchen
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encountered errors when running
oidcc_plug.gen.controllerand found that the igniter task generates this code:(example using test values)
This causes auth errors to not render at all.
This pr updates the path to
lib/test_web/controllers/auth_html.exand removed the redundantdefmoduleline.Also changes the test for that module to reflect those changes.