Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 60cc74d8a7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "copy-fonts": "node -e \"const fs=require('fs');const path=require('path');const src=path.join(process.cwd(),'node_modules/katex/dist/fonts');const dest=path.join(process.cwd(),'fonts');if(!fs.existsSync(src)){console.error('Run npm install first (katex is a devDependency)');process.exit(1);}fs.mkdirSync(dest,{recursive:true});fs.readdirSync(src).forEach(f=>fs.copyFileSync(path.join(src,f),path.join(dest,f)));console.log('Fonts copied to fonts/');\"", | ||
| "prepublishOnly": "npm run build" | ||
| "prepublishOnly": "npm run build", | ||
| "test": "npm run build:ts && node --test tests/*.test.mjs" |
There was a problem hiding this comment.
Generate the WASM pkg before running tests
In a clean checkout this new test target stops in the TypeScript build before any tests run: build:ts compiles src/index.ts, which imports ../pkg/ratex_wasm.js, but pkg/ is generated by build:wasm and is not committed (I checked rg --files platforms/web and there is no platforms/web/pkg). I verified tsc -p platforms/web/tsconfig.build.json fails with TS2307, so npm test only works after a prior WASM build; run build:wasm or provide a test stub/declaration before build:ts.
Useful? React with 👍 / 👎.
…ge and add new display mode tests
Deploying ratex with
|
| Latest commit: |
a56ccc7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://71898600.ratex.pages.dev |
| Branch Preview URL: | https://feat-wasm.ratex.pages.dev |
No description provided.