Change Linter to CLIEngine to use plugins on ESLint

[americoneto1]

Actually, Plato uses linter verify as you can see below:
https://github.com/es-analysis/plato/blob/master/lib/reporters/eslint/index.js#L39

But using linter on this way, eslint plugins doesn't work. ESLint team recommends use CLIEngine instead of Linter Verify (eslint/eslint#4119 (comment)).

Could you please validate this PR and if it's OK procceds with merge on master branch?

Thank you!

[americoneto1]

Anyone can check this PR?

[jsoverson]

Thanks @americoneto1, can you add some tests for eslint in general? I don't use this functionality and don't know the use cases to test for (eg eslintrcs, plugins, etc).

[ColCh]

@americoneto1 we can't use another name for eslint config instead of .eslintrc?

[conradoqg]

Please, merge this pull request. This made eslint work.

[americoneto1]

@ColCh As far as I know, when we use CLIEngine, the eslint file name must be .eslintrc.
@conradoqg Did you test this PR on your project?

[conradoqg]

Look at the recent pull request i made to your fork. There, you need to pass the config path, instead of an object. With a json file, it worked for me.

[JSlain]

This pull request is still actuality.
However, the new test is failing...
It relies on 2 other existing fixture files (a and b), and on a default ESLint configuration.
The meaning of "extends": "eslint:recommended" changes over time, this makes the test hard to maintain.
I think the test shouldn't rely on this extends.

[jmullo]

Is there another way to get ESLint plugins to work before this is fixed?

[ColCh]

@jmullo use forks
https://github.com/Lingvokot/es6-plato this on one is used by me. However, I don't recommend it :)