Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I raised an issue to be able to configure multiple webhooks for different types, and this PR addresses that - however I ran into a more pressing related need.
We need different headers for different documents, but after reviewing the chrome print handling and html-chrome-pdf, the only way this seems possible is via the printOptions value in html-chrome-pdf - so I made this change to allow for configuring different headers. I left the existing configuration alone, so the webhook and generator configuration at the top level can be considered the default (if no doctype is specified or no webhook/generator is specified for a doctype.
Finally there didn't seem to be a way to select a s3 configuration, so I mapped this to doctype (otherwise it uses the full set as currently configured).