Worktree-Isolated Multi-Agent Runs with Secure Manager Logs#2489
Worktree-Isolated Multi-Agent Runs with Secure Manager Logs#2489SivanCola wants to merge 4 commits into
Conversation
|
@codex review |
|
CI follow-up: fixed the Ubuntu failure by configuring a local git identity in the test repository used by TestAgentsManagerActionsMergeAndCleanup, so the test merge commit no longer depends on runner-global git config. The subsequent macOS failure was an actions/setup-go DNS failure before project code ran; I retriggered CI with an empty commit because I do not have admin rights to rerun jobs directly.\n\nVerification:\n- env HOME=$(mktemp -d) go test ./internal/agent -run TestAgentsManagerActionsMergeAndCleanup -count=1\n- go test ./...\n- go vet ./...\n- gofmt check for the root module\n- git diff --check\n\nLatest GitHub checks are now green on ubuntu-latest and macos-latest. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 14c995e44e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
The worktree isolation and the 0600/0700 manager run-logs are genuinely nice pieces of engineering, and I read through the whole thing. I can't take the core of it, though. The If you want to land the useful parts, the path is the #2463 shape: a user-invoked skill with |
Summary
Adds a first-class
agentstool for coordinated multi-agent runs, including read-only parallel exploration, worktree-isolated write agents, DAG dependencies, branch/commit summaries, merge planning, and desktop visibility for nested agent activity.Root Cause
The previous sub-agent flow could delegate focused work, but it did not provide a durable manager-level contract for physically isolated write agents, branch/commit receipts, or persisted run state. Plugin/MCP tools also needed to be rebound per worktree so child agents operate against the intended workspace instead of the parent process directory.
Technical Approach
agentsbatch tool that runs up to four sub-agents with per-agentsessionorworktreeisolation,read_onlyorwritemode, DAGdepends_onordering, and branch/worktree defaults.Focused Optimization Points
0700directory,0600files) and redact full agent prompts while preserving prompt byte counts for auditability...escapes,.roots, and symlink escapes.OpenPathis restricted to the current workspace, registered git worktrees, and manager-run logs; it rejects arbitrary files and.appbundles.mcp__...tool is explicitly requested.Verification
go test ./...(cd desktop && go test ./...)npm --prefix desktop/frontend run buildgit diff --check