Import cc-switch MCP servers selectively#2499
Open
SivanCola wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aabac57156
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a focused cc-switch MCP import path without bringing over the closed v1 desktop port:
reasonix mcp importimports Codex-enabled MCP servers from cc-switch into Reasonix config./mcp importin chat opens a selectable picker so risky or personal servers can be left unchecked.Root Cause
Users who already curate MCP servers in cc-switch had to re-enter those servers manually in Reasonix. The previous large PR mixed this useful import behavior with a wholesale v1 desktop frontend port, making the valuable MCP piece hard to review and merge independently.
Technical Approach
This PR keeps the change scoped to MCP import and config mutation:
~/.cc-switch/cc-switch.dbwith deterministicORDER BY namefiltering on Codex-enabled servers.config.json,config.json.migrated, andconfig.json.bakonly when the SQLite DB is absent.config.PluginEntryvalues and validates them through the existing plugin validator.Focused Optimization Points
auto_startsemantics in this PR.internal/bootor plugin startup behavior.Cache / Tool Schema Notes
This PR does not change the default provider-visible tool schema during normal startup. Tool schema changes only happen after an explicit user action (
/mcp import) or on the next session after imported MCP servers are present in config, which matches existing MCP add behavior.Verification
Passed:
go test ./internal/config ./internal/control ./internal/cligo test ./internal/agent -run TestPlanModeDoesNotMutateSystemOrToolsgo test ./internal/plugin ./internal/config ./internal/control ./internal/cliAlso ran
go test ./...; it failed ininternal/boot TestBuildDiscoversSkillsbecause this local machine's global skills were discovered and included in the boot prompt. The failure is environment-dependent and unrelated to this PR's MCP import changes.