[fix] desktop model switch rebuilds#2768
Closed
paradoxSCH wants to merge 1 commit into
Closed
Conversation
f5c0ebd to
753ac0e
Compare
753ac0e to
bbe4a7a
Compare
bbe4a7a to
a365331
Compare
Owner
|
Thanks @paradoxSCH — the close-before-rebuild bug is real and still present on main-v2. #2928's multi-tab refactor moved every field this PR touched ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2644
Summary
Root cause
On Windows the default bash sandbox mode is
enforce, but there is no OS sandbox implementation for bash on that platform. The CLI warning is correct for terminal flows, but desktop rebuilds controllers during model/settings changes and inherited the default stderr path, so the warning appeared during model switching. At the same time, failed rebuilds could close or clear the existing controller before the replacement had been built.Latest rebase
Rebased onto
main-v2ata478e501on 2026-06-03. The PR remains mergeable after resolving conflicts indesktop/app_test.goanddesktop/settings_app.go.Verification
go test . -run TestScheduleSnapshotCoalesces -count=50fromdesktop/go vet ./...fromdesktop/go build ./...fromdesktop/go test ./...fromdesktop/go test ./internal/boot ./internal/config ./internal/sandboxnpm run typecheckfromdesktop/frontend/currently fails on latest upstream in untouched files:src/components/ApprovalModal.tsx:RefObject<HTMLDivElement | null>vsRefObject<HTMLDivElement>src/components/AskCard.tsx: same ref type mismatchNote: local commit/push hooks currently run npm from the repository root where no
package.jsonexists, so push updates used--no-verifyafter the checks above passed.